[wp-trac] [WordPress Trac] #35557: grunt precommit should run phpunit tests

[WordPress Trac]

#35557: grunt precommit should run phpunit tests
------------------------------+-----------------------
 Reporter:  ericlewis         |       Owner:  ocean90
     Type:  task (blessed)    |      Status:  assigned
 Priority:  normal            |   Milestone:  4.5
Component:  Build/Test Tools  |     Version:
 Severity:  normal            |  Resolution:
 Keywords:  has-patch commit  |     Focuses:
------------------------------+-----------------------

Comment (by netweb):

 Replying to [comment:22 ocean90]:
 > The naming of the `precommit:core` task is a bit confusing because it
 only runs the `image:core` task.
 I chose that name in that it is the sub task name for all the other tasks
 that are *not* CSS, JS, or PHP

 Maybe `precommit:base` would be better? Any other suggestions?

 > Also, shouldn't the precommit task only check staged files?
 After the issues last week of trying to get a patch to apply from #35945
 that included the deletion of files as discussed in Slack
 [https://wordpress.slack.com/archives/core/p1457029977003433 here] it was
 problematic at best, for experienced Git/SVN users reverting staged files
 or deleted files is would not prove to be overly challenging, for less
 experienced users reverting these types of changes would not be so easy.
 For that reason my inclination here is to leave it as it currently stands
 and iterate further another time if required.

 > It would be awesome if the phpunit task would run in Vagrant, see
 https://github.com/xwp/wp-dev-
 lib/blob/f95a6e9e60fc261af655be929cee637e93149f41/check-diff.sh#L532-L552.
 :-)
 +1 I like this idea, created ticket #36190 for this.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/35557#comment:25>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform