[wp-trac] [WordPress Trac] #34945: HTTPS website with HTTP images

[WordPress Trac]

#34945: HTTPS website with HTTP images
-------------------------------------------------+-------------------------
 Reporter:  Angristan                            |       Owner:
     Type:  defect (bug)                         |  johnbillion
 Priority:  normal                               |      Status:  reopened
Component:  Media                                |   Milestone:  4.5
 Severity:  normal                               |     Version:  4.4
 Keywords:  https has-patch has-unit-tests       |  Resolution:
  commit                                         |     Focuses:
-------------------------------------------------+-------------------------

Comment (by jeremyfelt):

 Replying to [comment:47 azaozz]:
 > Looking at this more: there is little benefit in caching as
 `parse_url()` is quite fast. The 1-2 microseconds we could save are
 probably lost in calling another function. Lets go with 34945.3.diff until
 this is added to `wp_get_upload_dir()`.

 The new wrapper may still be useful for us even without caching.

 [attachment:34945.4.diff] uses the new `_ssl_image_baseurl()` in
 `wp_get_attachment_url()`. This clears up a bunch of #34109, though
 results in HTTPS URLs being inserted in the content. As @joemcgill
 mentioned in that ticket - "we could do a reverse check in get_image_tag()
 to set the scheme back to match the scheme of siteurl before inserting
 content in the editor"

--
Ticket URL: <https://core.trac.wordpress.org/ticket/34945#comment:48>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform