[wp-trac] [WordPress Trac] #36083: Media Grid: 'wp-admin/upload.php' broken in nightly builds

[WordPress Trac]

#36083: Media Grid: 'wp-admin/upload.php' broken in nightly builds
---------------------------------------------+-----------------------------
 Reporter:  joemcgill                        |       Owner:  joemcgill
     Type:  defect (bug)                     |      Status:  closed
 Priority:  high                             |   Milestone:  4.5
Component:  Media                            |     Version:  trunk
 Severity:  major                            |  Resolution:  fixed
 Keywords:  has-patch has-unit-tests commit  |     Focuses:  administration
---------------------------------------------+-----------------------------
Changes (by ocean90):

 * status:  reopened => closed
 * resolution:   => fixed


Comment:

 In [changeset:"36885"]:
 {{{
 #!CommitTicketReference repository="" revision="36885"
 Tests: Remove `test_new_files_are_not_in_old_files_array()` from [36843].

 The test assumes that if a CSS file was added to `$_old_files` all three
 files (.css, .min.css, -rtl.min.css; it's actually missing the fourth
 case, -rtl.css) don't exist anymore. But this isn't always the case. The
 test is also incredible slow because it does three `file_exists()` checks
 for each file — the global contains 646 files currently.

 It's important what we have in the /build directory and that's covered by
 `test_new_files_are_not_in_old_files_array_compiled()`.

 Fixes #36083.
 }}}

--
Ticket URL: <https://core.trac.wordpress.org/ticket/36083#comment:21>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform