[wp-trac] [WordPress Trac] #35945: Site Logo: reconsider the `site` terminology in code

WordPress Trac noreply at wordpress.org
Sat Mar 5 22:15:10 UTC 2016

#35945: Site Logo: reconsider the `site` terminology in code
 Reporter:  celloexpressions          |       Owner:  obenland
     Type:  defect (bug)              |      Status:  reopened
 Priority:  normal                    |   Milestone:  4.5
Component:  Customize                 |     Version:  trunk
 Severity:  normal                    |  Resolution:
 Keywords:  needs-patch dev-feedback  |     Focuses:

Comment (by westonruter):

 Replying to [comment:14 celloexpressions]:
 > I'm guessing there are other ways to achieve the same results, as
 Obenland mentioned, and if a particular theme really needs it, they could
 add it.

 But this isn't just a matter of filtering `body_class` to include a filter
 if `has_custom_logo()`. To ensure the preview appears properly, they'd
 also need to add some JS to toggle this class on the body when the logo is
 added or removed (since the logo update applies with `postMessage` and
 selective refresh, without a full page refresh). True this is not hard,
 but it's one more thing a themer would have to be aware of and potentially
 incorporate into every theme built. It sounds like from @karmatosed and
 @iamtakashi that they think themes will need to add specific styling when
 a logo is present more often than not, so to me it seems that the body
 class should be added by default.

Ticket URL: <https://core.trac.wordpress.org/ticket/35945#comment:15>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform

More information about the wp-trac mailing list