[wp-trac] [WordPress Trac] #35982: The new feature 'site logo' is not working on-the-fly (postMessage)

WordPress Trac noreply at wordpress.org
Fri Mar 4 17:19:55 UTC 2016


#35982: The new feature 'site logo' is not working on-the-fly (postMessage)
--------------------------+--------------------------
 Reporter:  sidati        |       Owner:  westonruter
     Type:  defect (bug)  |      Status:  reopened
 Priority:  normal        |   Milestone:  4.5
Component:  Customize     |     Version:  trunk
 Severity:  normal        |  Resolution:
 Keywords:                |     Focuses:  javascript
--------------------------+--------------------------
Changes (by westonruter):

 * keywords:  reporter-feedback =>


Comment:

 @sidati thank you. OK, this confirms what I suspected. Again, the setting
 is added with `postMessage` by default, so you're setting it to
 `postMessage` made no difference. The problem was that you manually
 embedded the site logo using a class name other than the one output by
 `the_site_logo()`, and since no element in the document had the `site-
 logo-link` class, this then resulted in the partial's fallback logic of
 refreshing the entire preview to happen.

 @obenland This relates to what we talked about in regards to having site
 title and tagline have default selective refresh irrespective of the
 theme. This was not implemented for site title and tagline, instead opting
 for each theme to explicitly add support, see #33738. I wonder if the same
 should be done for site logo, to remove the partial from being added in
 `WP_Customize_Manager` to instead add it explicitly by the theme?

--
Ticket URL: <https://core.trac.wordpress.org/ticket/35982#comment:5>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list