[wp-trac] [WordPress Trac] #18900: Add a few more hide-if-no-js classes

[WordPress Trac]

#18900: Add a few more hide-if-no-js classes
-------------------------------------------+-------------------------------
 Reporter:  johnbillion                    |       Owner:  rianrietveld
     Type:  enhancement                    |      Status:  assigned
 Priority:  normal                         |   Milestone:  4.6
Component:  Administration                 |     Version:  3.3
 Severity:  normal                         |  Resolution:
 Keywords:  needs-testing has-patch close  |     Focuses:  ui,
                                           |  accessibility
-------------------------------------------+-------------------------------
Changes (by ocean90):

 * keywords:  needs-testing has-patch => needs-testing has-patch close


Comment:

 @Mte90, @chriscct7: `src/wp-admin/includes/media.php` requires single
 quotes because the string is wrapped with double quotes.

 [attachment:18900.4.patch] adds the classes only to deprecated
 functionality. `themes.php?page=custom-background` and `themes.php?page
 =custom-header` are only accessible when JS is disabled. We could add the
 class to the buttons but I don't think that the extra message is
 necessary.

 The class in`get_media_item()` seems to be useless because the whole media
 stuff requires JS to work properly. You can test this by opening `wp-admin
 /media-upload.php?type=image&tab=type` in a new tab. Append
 `&post_id=$post_id` to get the media of a specific post.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/18900#comment:19>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform