[wp-trac] [WordPress Trac] #34936: Reconcile wp-settings-cli.php with wp-settings.php

[WordPress Trac]

#34936: Reconcile wp-settings-cli.php with wp-settings.php
-------------------------------------------+-----------------------
 Reporter:  danielbachhuber                |       Owner:  jorbin
     Type:  enhancement                    |      Status:  assigned
 Priority:  normal                         |   Milestone:  4.6
Component:  Bootstrap/Load                 |     Version:
 Severity:  normal                         |  Resolution:
 Keywords:  dev-feedback wp-cli has-patch  |     Focuses:
-------------------------------------------+-----------------------

Comment (by DrewAPicture):

 @jorbin [attachment:34936.3.diff] is a great improvement.

 In [attachment:34936.4.diff] I've made a few key adjustments:

 * Typically we don't describe what filters can "allow" but in the case of
 boolean filters like this, it's kind of the point. We're explicitly
 filtering whether to allow something to happen. '''Thus, I've adjusted the
 summaries to reflect those allowances'''
 * I've also fixed some hook doc syntax and added more complete
 descriptions for parameters.
 * I've adjusted the hook names to more closely reflect their intent (see
 my first point about "allowances"): `enable_maintenance_mode_checks`,
 `enable_wp_debug_mode_checks`, `enable_loading_advanced_cache`.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/34936#comment:28>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform