[wp-trac] [WordPress Trac] #32787: make_clickable filter

WordPress Trac noreply at wordpress.org
Wed Jun 8 19:27:09 UTC 2016


#32787: make_clickable filter
----------------------------------------+------------------------------
 Reporter:  tlexcellent                 |       Owner:  johnjamesjacoby
     Type:  enhancement                 |      Status:  assigned
 Priority:  normal                      |   Milestone:  4.6
Component:  Formatting                  |     Version:  0.71
 Severity:  normal                      |  Resolution:
 Keywords:  has-patch needs-unit-tests  |     Focuses:
----------------------------------------+------------------------------

Comment (by johnjamesjacoby):

 Replying to [comment:12 ocean90]:
 > @johnjamesjacoby Can you refresh your patch based on @DrewAPicture's
 feedback? Is there already enough test coverage for the new functions? I
 think there should be at least one which tests the output when one of the
 filters is removed.

 Yes, I can.

 I think the test coverage for the existing code is okay. There are 24
 tests for `make_clickable()` but I like your idea of including a test that
 removes one of these filters and confirms the others still work okay, so
 I'll include that in the next patch.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/32787#comment:13>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list