[wp-trac] [WordPress Trac] #36487: Hierarchical comments do not display on second call of comments_template

[WordPress Trac]

#36487: Hierarchical comments do not display on second call of comments_template
--------------------------+---------------------------
 Reporter:  cookiesowns   |       Owner:  boonebgorges
     Type:  defect (bug)  |      Status:  closed
 Priority:  high          |   Milestone:  4.6
Component:  Comments      |     Version:  4.4.2
 Severity:  normal        |  Resolution:  fixed
 Keywords:  has-patch     |     Focuses:
--------------------------+---------------------------
Changes (by boonebgorges):

 * status:  assigned => closed
 * resolution:   => fixed


Comment:

 In [changeset:"37625"]:
 {{{
 #!CommitTicketReference repository="" revision="37625"
 Comments: Improve caching for hierarchical queries.

 Hierarchical comment queries work by first fetching the IDs of top-level
 comments, and then filling the descendant tree one level at a time based
 on the
 top-level results. When top-level comment IDs are found in the cache,
 `WP_Comment_Query` does not generate the SQL used to fetch these comments.
 In
 this case, the `fill_descendants()` query does not have enough information
 to fill children. As a result, descendant comments were failing to be
 filled
 in cases where the top-level comments were found in the cache.

 This was a minor bug previously, because comment caches were not
 maintained
 between pageloads. Since comment caches are now persistent [37613], the
 problem
 becomes evident anywhere that a persistent object cache is in use.

 The solution is to cache parent-child relationships, so that when top-
 level
 comments are found in the cache, descendant comments should be found there
 as
 well.

 Fixes #36487.
 }}}

--
Ticket URL: <https://core.trac.wordpress.org/ticket/36487#comment:4>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform