[wp-trac] [WordPress Trac] #37470: Shiny Updates: Erroneous Plugin Deactivation

[WordPress Trac]

#37470: Shiny Updates: Erroneous Plugin Deactivation
----------------------------+-----------------------
 Reporter:  voldemortensen  |       Owner:
     Type:  defect (bug)    |      Status:  reopened
 Priority:  normal          |   Milestone:  4.6
Component:  Plugins         |     Version:  4.2.4
 Severity:  normal          |  Resolution:
 Keywords:                  |     Focuses:
----------------------------+-----------------------
Changes (by Otto42):

 * milestone:  Awaiting Review => 4.6


Comment:

 Confirmed on a 4.1.5 install compared to trunk.

 However, you can duplicate the results of Shiny Updates in trunk in that
 4.1.5 install by using the "Bulk Actions" menu to perform the update. The
 checkbox->select Upgrade->click apply flow has the same result of
 deactivating your new plugin.

 The reason for this is apparently the differences between the
 bulk_upgrade() function and the normal upgrade() functions found in the
 Plugin_Upgrader class.

 The wp_ajax_update_plugin() function is calling bulk_upgrade(), so using
 the bulk-upgrade method of previous versions will act the same way:

 https://core.trac.wordpress.org/browser/trunk/src/wp-admin/includes/ajax-
 actions.php#L3683

--
Ticket URL: <https://core.trac.wordpress.org/ticket/37470#comment:7>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform