[wp-trac] [WordPress Trac] #37439: Why is "input_attrs" attribute not used in Customizer checkbox, radio, select, textarea controls?

WordPress Trac noreply at wordpress.org
Fri Jul 22 04:14:00 UTC 2016


#37439: Why is "input_attrs" attribute not used in Customizer checkbox, radio,
select, textarea controls?
-------------------------------------+------------------------------
 Reporter:  Collizo4sky              |       Owner:
     Type:  enhancement              |      Status:  new
 Priority:  normal                   |   Milestone:  Awaiting Review
Component:  Customize                |     Version:  trunk
 Severity:  normal                   |  Resolution:
 Keywords:  reporter-feedback close  |     Focuses:  ui
-------------------------------------+------------------------------
Changes (by westonruter):

 * keywords:  reporter-feedback => reporter-feedback close


Comment:

 @Collizo4sky I would say you're probably taking the wrong approach. The
 contents of the controls really should be considered a black box (shadow
 DOM) where JS outside of the control shouldn't be directly interacting
 with the contents of the control like that. I think you should take
 inspiration from the `show_on_front` setting in the Static Front Page
 section, and how changing this setting causes the controls for Page on
 Front and Page for Posts to show or hide. For a somewhat dense example,
 see: https://core.trac.wordpress.org/browser/tags/4.5.3/src/wp-admin/js
 /customize-controls.js#L3754

--
Ticket URL: <https://core.trac.wordpress.org/ticket/37439#comment:3>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list