[wp-trac] [WordPress Trac] #36627: Theme preview/details: change non-links to buttons and remove disabled buttons from tabindex

[WordPress Trac]

#36627: Theme preview/details: change non-links to buttons and remove disabled
buttons from tabindex
----------------------------------+----------------------------------------
 Reporter:  walbo                 |       Owner:
     Type:  defect (bug)          |      Status:  new
 Priority:  normal                |   Milestone:  Future Release
Component:  Themes                |     Version:
 Severity:  normal                |  Resolution:
 Keywords:  has-patch needs-      |     Focuses:  accessibility, javascript
  refresh                         |
----------------------------------+----------------------------------------
Changes (by afercia):

 * keywords:  has-patch => has-patch needs-refresh
 * focuses:  accessibility => accessibility, javascript
 * milestone:  Awaiting Review => Future Release


Comment:

 Thanks @walbo yes the theme browser needs some accessibility improvements
 and many of the points you outlined are perfectly valid. Many things have
 changed in the last months, see for example [38084] that added a
 `disabled` attribute on the next/prev navigation to take them out from the
 tab order when they're... disabled :)

 Other things need to be fixed yet, for example some buttons miss a
 `type="button"` attribute and the JS part could be probably simplified.
 Also, some links (with a few exceptions for the ones that still work when
 JS is off) need to be buttons.

 I'd suggest to keep things separated though and open a separate ticket for
 the theme installer. Keeping the issues related to the theme browser in
 this ticket and addressing the theme installer issues in a separate ticket
 would help to make things more clear for other contributors and reviewers.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/36627#comment:2>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform