[wp-trac] [WordPress Trac] #37378: 4.6 breaks tax query alterations (i.e. INNER_JOIN)

[WordPress Trac]

#37378: 4.6 breaks tax query alterations (i.e. INNER_JOIN)
--------------------------+---------------------------
 Reporter:  nimmolo       |       Owner:  boonebgorges
     Type:  defect (bug)  |      Status:  closed
 Priority:  normal        |   Milestone:  4.6
Component:  Taxonomy      |     Version:  trunk
 Severity:  normal        |  Resolution:  fixed
 Keywords:                |     Focuses:
--------------------------+---------------------------
Changes (by boonebgorges):

 * status:  assigned => closed
 * resolution:   => fixed


Comment:

 In [changeset:"38099"]:
 {{{
 #!CommitTicketReference repository="" revision="38099"
 Taxonomy: Improve back compat of values passed to 'terms_clauses' filter.

 Prior to the introduction of `WP_Term_Query`, the 'orderby' clause
 passed to the 'terms_clauses' filter was prefixed by `ORDER BY`. After
 `WP_Term_Query`, this was not the case; `ORDER BY` was added after the
 filter. As such, plugins filtering 'terms_clauses' and returning an
 'orderby' clause beginning with `ORDER BY` resulted in invalid syntax
 when `WP_Term_Query` prepended a second `ORDER BY` keyword to
 the clause.

 This changeset rearranges the way the 'orderby' clause is built so that
 it will be passed to 'terms_clauses' in the previous format.

 Fixes #37378.
 }}}

--
Ticket URL: <https://core.trac.wordpress.org/ticket/37378#comment:5>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform