[wp-trac] [WordPress Trac] #37233: Shiny Updates: "Add New Plugin" shiny search issues

[WordPress Trac]

#37233: Shiny Updates: "Add New Plugin" shiny search issues
-------------------------------------+-------------------------------------
 Reporter:  afercia                  |       Owner:  swissspidy
     Type:  defect (bug)             |      Status:  assigned
 Priority:  high                     |   Milestone:  4.6
Component:  Plugins                  |     Version:  trunk
 Severity:  major                    |  Resolution:
 Keywords:  has-screenshots shiny-   |     Focuses:  ui, accessibility,
  updates has-patch                  |  javascript
-------------------------------------+-------------------------------------

Comment (by afercia):

 Quickly tested [attachment:37233.diff] and the disappearing results thing
 seems fixed :) Noticed some outstanding and new issues though:

 1
 on `$pluginInstallSearch` the `search` non-standard event should be
 changed in `input` as already done for `$pluginSearch`.

 2
 the results count message for `wp.a11y.speak()` is not correct when there
 are more than 30 results. I guess this depends on the fact the current
 results count is based on the plugin install list table "per page" limit
 while it should be based on the total items count:
 [[Image(https://cldup.com/lkNFmLxPyB.png)]]


 3
 seems the AJAX search doesn't take into account the search "type" set with
 the select options (works correctly with JS off). In the example in the
 screenshot below, the search for "author johnbillion" should return 21
 results:

 [[Image(https://cldup.com/jHudZTcMvV.png)]]

--
Ticket URL: <https://core.trac.wordpress.org/ticket/37233#comment:16>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform