[wp-trac] [WordPress Trac] #37223: Fatal error when adding a new multi-site user due to incorrect error handling.

[WordPress Trac]

#37223: Fatal error when adding a new multi-site user due to incorrect error
handling.
--------------------------+------------------------
 Reporter:  pbogdan       |       Owner:  flixos90
     Type:  defect (bug)  |      Status:  assigned
 Priority:  normal        |   Milestone:  4.6
Component:  Users         |     Version:  4.5
 Severity:  normal        |  Resolution:
 Keywords:  has-patch     |     Focuses:  multisite
--------------------------+------------------------
Changes (by jeremyfelt):

 * keywords:  needs-unit-tests needs-patch => has-patch
 * severity:  major => normal


Comment:

 [attachment:37223.diff] fixes the fatal error by redirecting without a
 user ID of the activation response is an error.

 This works for short term. We should probably figure out (in another
 ticket) what needs to be communicated when an error is returned here.
 Right now it's "User has been added to your site." no matter what the
 error is.

 I don't think there's a friendly way to unit test this without doing some
 abstraction of the user-new screen.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/37223#comment:6>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform