[wp-trac] [WordPress Trac] #14134: Menus item are limited to 16 item and will not save more than that

WordPress Trac noreply at wordpress.org
Fri Jan 29 18:14:58 UTC 2016


#14134: Menus item are limited to 16 item and will not save more than that
-------------------------------------------------+-------------------------
 Reporter:  jaanfx                               |       Owner:
     Type:  defect (bug)                         |      Status:  reviewing
 Priority:  high                                 |   Milestone:  4.5
Component:  Menus                                |     Version:  3.0
 Severity:  major                                |  Resolution:
 Keywords:  needs-testing needs-unit-tests dev-  |     Focuses:
  feedback needs-patch                           |
-------------------------------------------------+-------------------------
Changes (by ericlewis):

 * keywords:  has-patch needs-testing needs-unit-tests dev-feedback =>
     needs-testing needs-unit-tests dev-feedback needs-patch


Comment:

 Had a good chat with @chriscct7 about unit test approach here.

 Let's try to unit test this by spoofing the HTML form submit request. We
 can set the number of menu items in relation to the `max_input_vars`
 setting.

 Also from @chriscct7:

 > is you might want to check json_last_error() or something after json
 decoding it. If you don't have an array you're iterating the for loop to
 back insert the data into $_POST on what could be NULL

 so we should consider an updated patch with that in mind.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/14134#comment:189>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list