[wp-trac] [WordPress Trac] #35188: Pass nonce action from "nonce_life" filter

WordPress Trac noreply at wordpress.org
Wed Jan 27 09:59:56 UTC 2016


#35188: Pass nonce action from "nonce_life" filter
----------------------------------------+------------------------------
 Reporter:  giuseppe.mazzapica          |       Owner:
     Type:  feature request             |      Status:  new
 Priority:  normal                      |   Milestone:  Awaiting Review
Component:  General                     |     Version:
 Severity:  normal                      |  Resolution:
 Keywords:  needs-patch good-first-bug  |     Focuses:
----------------------------------------+------------------------------

Comment (by giuseppe.mazzapica):

 Hi @dwainm, thanks.

 I think there are some issues in the patch.

 In `wp_verify_nonce` default action is `-1` and probably that should be
 used in `wp_nonce_tick` as well. (And doc bloc should say `string|int`).

 Moreover, `wp_nonce_tick` is used in `wp_create_nonce` and not only in
 `wp_verify_nonce`.

 Last very minor thing, there's an alignment issue in the doc bloc.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/35188#comment:3>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list