[wp-trac] [WordPress Trac] #27048: Export: Allow multiple post types to be selected

[WordPress Trac]

#27048: Export: Allow multiple post types to be selected
-------------------------------------------------+-------------------------
 Reporter:  hlashbrooke                          |       Owner:
     Type:  enhancement                          |      Status:  new
 Priority:  normal                               |   Milestone:  Future
Component:  Export                               |  Release
 Severity:  normal                               |     Version:  3.8
 Keywords:  has-patch has-screenshots needs-     |  Resolution:
  unit-tests                                     |     Focuses:
                                                 |  administration
-------------------------------------------------+-------------------------
Changes (by netweb):

 * keywords:  has-patch has-screenshots => has-patch has-screenshots needs-
     unit-tests


Comment:

 @hlashbrooke I'm adding back the `needs-unit-tests` keyword, there aren't
 actually and existing tests, hence one of the reasons of importance for
 them. (They are only included in the Export API patch)

 My biggest concern in your latest patch is the switch from '''raw MySQL'''
 queries to `WP_Query`.

 An example of this was r36068 that shipped with WordPress 4.4.1 which
 reverted a change to `WP-Query` from '''raw MySQL''' queries in WordPress
 4.4 for non-public post types, as such testing post types defined with
 `exclude_from_search` and custom post statuses will be required to be
 tested here.

 My knowledge of units testing has come a long way since my last comment in
 this ticket 2 years ago so I'll try and find some time to see if I can get
 some tests up and running.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/27048#comment:34>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform