[wp-trac] [WordPress Trac] #35557: grunt precommit should run phpunit tests

WordPress Trac noreply at wordpress.org
Sat Jan 23 23:49:27 UTC 2016


#35557: grunt precommit should run phpunit tests
------------------------------+-----------------------------
 Reporter:  ericlewis         |       Owner:
     Type:  enhancement       |      Status:  new
 Priority:  normal            |   Milestone:  Future Release
Component:  Build/Test Tools  |     Version:
 Severity:  normal            |  Resolution:
 Keywords:  has-patch         |     Focuses:
------------------------------+-----------------------------

Comment (by jorbin):

 Quick notes on the patch so these pieces aren't forgotten:

 1) let's not get rid of the description.  It's valuable if you run `grunt
 --help` to see the description.

 2) ` Bail if the svn diff command returned a non-zero exit code.` We
 should pass either `false` or an `Error` object so the task is a failure
 rather then just bailing.

 Otherwise, solid start.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/35557#comment:7>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list