[wp-trac] [WordPress Trac] #35557: grunt precommit should run phpunit tests

WordPress Trac noreply at wordpress.org
Fri Jan 22 00:25:01 UTC 2016


#35557: grunt precommit should run phpunit tests
------------------------------+------------------------------
 Reporter:  ericlewis         |       Owner:
     Type:  enhancement       |      Status:  new
 Priority:  normal            |   Milestone:  Awaiting Review
Component:  Build/Test Tools  |     Version:
 Severity:  normal            |  Resolution:
 Keywords:                    |     Focuses:
------------------------------+------------------------------

Comment (by voldemortensen):

 if i'm making CSS changes i don't want to run [phpunit] tests, but that's
 specific to those commits :)

 I agree with this, but the same argument could be made for the js and
 image tasks. Those seem unnecessary for css changes.

 As I'm not a committer I don't know the pains of it, but to me it makes
 sense to give options. i.e. pass `--no-phpunit` to skip phpunit tests,
 `--no-js` to skip js, etc. The default would run all of them.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/35557#comment:4>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list