[wp-trac] [WordPress Trac] #26005: Internal jump links and shift-clicking on links in widgets (to edit) erroneously cause navigation in Customizer preview

WordPress Trac noreply at wordpress.org
Thu Jan 21 06:07:48 UTC 2016


#26005: Internal jump links and shift-clicking on links in widgets (to edit)
erroneously cause navigation in Customizer preview
--------------------------+-------------------------
 Reporter:  afercia       |       Owner:  MattGeri
     Type:  defect (bug)  |      Status:  closed
 Priority:  normal        |   Milestone:  4.5
Component:  Customize     |     Version:  3.4
 Severity:  normal        |  Resolution:  fixed
 Keywords:  has-patch     |     Focuses:  javascript
--------------------------+-------------------------
Changes (by westonruter):

 * status:  reviewing => closed
 * resolution:   => fixed


Comment:

 In [changeset:"36371"]:
 {{{
 #!CommitTicketReference repository="" revision="36371"
 Customizer: Fix `click.preview` event handler for jump links and
 shift+clicks in preview.

 * Prevent following jump links (starting with `#`), but instead scroll
 that element into view.
 * Prevent following links clicked in the Customizer if shift key is
 pressed when clicking; this fixes an issue when trying to shift-click on a
 widget or nav menu item (#32681) to just focus on the control in the
 Customizer.

 Fixes #26005.
 }}}

--
Ticket URL: <https://core.trac.wordpress.org/ticket/26005#comment:8>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list