[wp-trac] [WordPress Trac] #34350: Update Backbone to 1.2.3 and Underscore to 1.8.3

WordPress Trac noreply at wordpress.org
Tue Jan 19 14:09:08 UTC 2016


#34350: Update Backbone to 1.2.3 and Underscore to 1.8.3
---------------------------------------+------------------------------
 Reporter:  caseypatrickdriscoll       |       Owner:  adamsilverstein
     Type:  enhancement                |      Status:  assigned
 Priority:  normal                     |   Milestone:  4.5
Component:  External Libraries         |     Version:  4.4
 Severity:  normal                     |  Resolution:
 Keywords:  needs-testing needs-patch  |     Focuses:  javascript
---------------------------------------+------------------------------

Comment (by ocean90):

 Replying to [comment:32 adamsilverstein]:
 > @ocean90 can you try patch [attachment:34350.6.diff] to see if that
 resolves your issue (I'm confused if i patch `media-audiovideo.js` or
 `media-details.js` so i did both (how are these built?)

 Run `grunt watch` and change the files in `/src/wp-includes/js/media`.
 Before creating the patch run `grunt precommit` once.

 [attachment:34350.6.diff] seems to work, not sure if the function()
 wrapper is really needed here. Using `_.defaults()` like in
 [source:/trunk/src/wp-includes/js/media/views/image-
 details.js?marks=18-26#L15] works too.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/34350#comment:34>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list