[wp-trac] [WordPress Trac] #35322: oEmbed generates link to an image in the wp-admin directory

[WordPress Trac]

#35322: oEmbed generates link to an image in the wp-admin directory
------------------------------------------------------+------------------
 Reporter:  nachtwaechter                             |       Owner:
     Type:  defect (bug)                              |      Status:  new
 Priority:  normal                                    |   Milestone:  4.5
Component:  Embeds                                    |     Version:  4.4
 Severity:  normal                                    |  Resolution:
 Keywords:  has-patch needs-refresh needs-unit-tests  |     Focuses:
------------------------------------------------------+------------------

Comment (by peterwilsoncc):

 Replying to [comment:11 swissspidy]:
 > Some notes on the second patch:
 >
 > * I wanted to create a new function  for that as well, though a name
 like `print_embed_site_title()` sounds better. No need for an `$echo`
 parameter though, just echo.
 > * The `sprintf` in that function is wrong. Also, the `admin_url(
 'images/w-logo-blue.png' )` fallback is not needed since there is always
 an site icon because of `has_site_icon()` check
 > * Tests for that function would be nice.

 FWIW, I think the second patch is too much for the benefit it provides. As
 a logo is an image and new files can be created in a major release, patch
 1 seems more appropriate.

 What are your thoughts?

--
Ticket URL: <https://core.trac.wordpress.org/ticket/35322#comment:12>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform