[wp-trac] [WordPress Trac] #34988: Screen Options on taxonomy edit screen

[WordPress Trac]

#34988: Screen Options on taxonomy edit screen
------------------------------+-----------------------------
 Reporter:  milindmore22      |       Owner:  swissspidy
     Type:  defect (bug)      |      Status:  assigned
 Priority:  normal            |   Milestone:  4.5
Component:  Taxonomy          |     Version:  4.4
 Severity:  normal            |  Resolution:
 Keywords:  has-patch commit  |     Focuses:  administration
------------------------------+-----------------------------

Comment (by boonebgorges):

 Thanks, @Ipstenu !

 Of those in your document:

 - BuddyPress is a false positive. The affected file is in the packaged
 bbPress, which is not used by default anymore, and is part of an AJAX
 handler that is never called in the BP context in any case.
 - `evergage` is a false positive. Appears to fire only on the front end,
 when `global $tag` shouldn't be populated (right?)
 - I'm pretty sure `lastfm-recent-tracks` is a false positive - it's using
 `$tag` to pass stuff around between XML-formatting callbacks. Same with
 `ml-social`, `mlv-contextual`
 - `socialmarketing` invokes the global but never uses it. Same with `wp-
 analitify`

 My impression from ten seconds looking at each is that only about five or
 six will out-and-out break if this change is made.

 I'm probably overly conservative, but given the limited upside of making
 the change, I'd leave it as `$tag`. (Another option: `$GLOBALS['tag'] =&
 $term`. Shudder.)

--
Ticket URL: <https://core.trac.wordpress.org/ticket/34988#comment:19>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform