[wp-trac] [WordPress Trac] #35356: wp_list_comments ignores $comments parameter

[WordPress Trac]

#35356: wp_list_comments ignores $comments parameter
-------------------------------------+---------------------------
 Reporter:  felser                   |       Owner:  boonebgorges
     Type:  defect (bug)             |      Status:  assigned
 Priority:  high                     |   Milestone:  4.4.2
Component:  Comments                 |     Version:  trunk
 Severity:  normal                   |  Resolution:
 Keywords:  has-patch needs-testing  |     Focuses:
-------------------------------------+---------------------------
Changes (by boonebgorges):

 * keywords:  needs-patch => has-patch needs-testing


Comment:

 Thanks for the patch, @ivankristianto. It's frustrating that the
 `separate_comments()` logic has to be reproduced, but like you, I can't
 see a better way of doing it without rewriting the whole function.

 [attachment:35356.diff] cleans up the formatting of the patch, and adds a
 unit test that demonstrates the issue. @felser or someone else having the
 problem, can you verify that the patch fixes the issue for you?

--
Ticket URL: <https://core.trac.wordpress.org/ticket/35356#comment:2>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform