[wp-trac] [WordPress Trac] #35075: Comment cache ignores custom query vars

[WordPress Trac]

#35075: Comment cache ignores custom query vars
-----------------------------+--------------------------
 Reporter:  jason_the_adams  |       Owner:
     Type:  defect (bug)     |      Status:  new
 Priority:  normal           |   Milestone:  4.5
Component:  Comments         |     Version:  trunk
 Severity:  normal           |  Resolution:
 Keywords:  has-patch        |     Focuses:  performance
-----------------------------+--------------------------

Comment (by jason_the_adams):

 @nacin I definitely grant you that, which is why I originally proposed
 this as filter to open the cache keys up to additional query_vars. In any
 case, it's a balance of caching enough, but not caching inappropriately.
 If custom query_vars are going to be supported, they can't be ignored in
 caching.

 >Also, any object relationships should probably be leveraged using Posts 2
 Posts, as that's likely what would be pulled into core if we did so (and
 are more likely than not going to do at some point).

 That's a whole other topic, which I'll refrain from going down too much,
 so suffice to say the Piklist team goes to great lengths to not break
 anything in core, while also not necessarily being limited by core. It
 largely attempts to draw out features in core that are largely unnoticed
 and extend it's capabilities. P2P is a bit limiting for our intentions,
 but if something like P2P was added to core, we'd make adjustments to play
 nicely with it as well. :)

--
Ticket URL: <https://core.trac.wordpress.org/ticket/35075#comment:23>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform