[wp-trac] [WordPress Trac] #35075: Comment cache ignores custom query vars

[WordPress Trac]

#35075: Comment cache ignores custom query vars
-----------------------------+--------------------------
 Reporter:  jason_the_adams  |       Owner:
     Type:  defect (bug)     |      Status:  new
 Priority:  normal           |   Milestone:  4.5
Component:  Comments         |     Version:  trunk
 Severity:  normal           |  Resolution:
 Keywords:  has-patch        |     Focuses:  performance
-----------------------------+--------------------------

Comment (by nacin):

 Replying to [comment:20 jason_the_adams]:
 > @nacin To be perfectly honest, I'm having a hard time figuring out what
 you mean in relation to the scope of this ticket. It sounds like you're
 talking about the $args as a whole, within the context of the function,
 while this ticket relates ''only'' to the $args as relate to the caching
 of the query. They're not affected for the entirety of the function, but
 only to be serialized and hashed.

 Sorry, I never bothered to close the loop there: My point is I suspect
 that this patch as written will suddenly cause a *lot* of queries to be
 cache misses.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/35075#comment:21>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform