[wp-trac] [WordPress Trac] #34945: HTTPS website with HTTP images

[WordPress Trac]

#34945: HTTPS website with HTTP images
--------------------------------------------+--------------------------
 Reporter:  Angristan                       |       Owner:  johnbillion
     Type:  defect (bug)                    |      Status:  reopened
 Priority:  normal                          |   Milestone:  4.4.1
Component:  Media                           |     Version:  4.4
 Severity:  normal                          |  Resolution:
 Keywords:  https has-patch has-unit-tests  |     Focuses:
--------------------------------------------+--------------------------

Comment (by mikeschroder):

 Replying to [comment:29 joemcgill]:
 > Unfortunately, we can't apply this logic directly in `wp_uploads_dir()`
 because that function is used to build URLs for content that is then
 inserted into posts in the database. Eventually, we should reverse all of
 this logic so that we default to HTTPS and make exceptions for the
 functions that insert content in the database, but for 4.4.1 a more
 conservative approach is probably wise.

 Agree that the most conservative fix we can do here is the way to go for
 4.4.1. Changing it where it only affects RespImg attributes seems the
 safest here, with expanding to a general remedy in 4.5. With that
 reasoning, `_wp_upload_dir_baseurl()` looks like the right choice here.

 I'd like to see this go out in 4.4.1, since we're talking about a
 regression in image display for front-end user content.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/34945#comment:33>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform