[wp-trac] [WordPress Trac] #35667: Maximum execution time error in WP_Text_Diff_Renderer_Table

[WordPress Trac]

#35667: Maximum execution time error in WP_Text_Diff_Renderer_Table
--------------------------------------------------+------------------
 Reporter:  ocean90                               |       Owner:
     Type:  defect (bug)                          |      Status:  new
 Priority:  normal                                |   Milestone:  4.5
Component:  Revisions                             |     Version:
 Severity:  normal                                |  Resolution:
 Keywords:  has-patch needs-testing dev-feedback  |     Focuses:
--------------------------------------------------+------------------
Changes (by codex-m):

 * keywords:  needs-patch => has-patch needs-testing dev-feedback


Comment:

 @ocean90 Thanks for the details. I'm able to replicate this issue too.
 However I'm not been able to replicate this in most cases. I have a local
 server with lots of memory/timeout settings and it works there.

 Meanwhile, on my standard local with limited timeout settings, it fails. I
 think that the best fix for now would be to use set_time_limit to a
 sensible amount which would work in all cases. This timeout fix won't
 introduce any side effects on our existing browse/diff implementation.

 I'm attaching a patch with setting the PHP timeout limit to 300. We are
 already using a fix like this in our wp-admin/includes/update-core.php
 (update-core function). We can also use this in the
 interleave_changed_lines functions where it can be used in situations
 requiring a long timeout.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/35667#comment:2>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform