[wp-trac] [WordPress Trac] #33755: Add Site Logo to WordPress Core

WordPress Trac noreply at wordpress.org
Wed Feb 24 11:29:00 UTC 2016

#33755: Add Site Logo to WordPress Core
 Reporter:  fatmedia                             |       Owner:
     Type:  feature request                      |      Status:  reopened
 Priority:  normal                               |   Milestone:  4.5
Component:  Customize                            |     Version:  trunk
 Severity:  normal                               |  Resolution:
 Keywords:  ux-feedback has-patch needs-testing  |     Focuses:  ui
  needs-unit-tests has-screenshots               |

Comment (by ocean90):

 * Is `WP_Site_Logo::preview_enqueue()` still needed? It tries to load a
 script via `plugins_url()`.
 * Can `_render_site_logo_partial()`be part of `WP_Site_Logo`?
 * `is_a()` should be `instanceof`, see [31188].
 * `images/browser.png` should be an absolute URL
 * I think the `restore_current_blog()` call in `get_the_site_logo()` is
 too early, so `home_url()` and `wp_get_attachment_image()` will return
 stuff for the current site. Not sure if that's intended. A unit test might
 be helpful to check this.
 * Should "a setting to hide header text" be moved into its own ticket?

Ticket URL: <https://core.trac.wordpress.org/ticket/33755#comment:103>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform

More information about the wp-trac mailing list