[wp-trac] [WordPress Trac] #34561: Abstract some embed template code into functions

WordPress Trac noreply at wordpress.org
Sun Feb 21 12:24:03 UTC 2016


#34561: Abstract some embed template code into functions
-------------------------------------+---------------------------
 Reporter:  johnbillion              |       Owner:  DrewAPicture
     Type:  enhancement              |      Status:  assigned
 Priority:  normal                   |   Milestone:  4.5
Component:  Embeds                   |     Version:  4.4
 Severity:  normal                   |  Resolution:
 Keywords:  has-patch needs-testing  |     Focuses:
-------------------------------------+---------------------------

Comment (by swissspidy):

 [attachment:34561.9.diff] is a streamlined version of the previous patches
 in need of some testing.

 By extending `locate_template()` to also look in `wp-includes/theme-
 compat` the template lookup can be greatly simplified. There shouldn't be
 any back-compat problems with that.

 The usage of `print_embed_thumbnail()` in this patch might seem weird. If
 anyone has a better solution (perhaps CSS only positioning?), let me know.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/34561#comment:31>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list