[wp-trac] [WordPress Trac] #18877: DRY up rewrite rule matching

WordPress Trac noreply at wordpress.org
Wed Feb 17 22:29:47 UTC 2016

#18877: DRY up rewrite rule matching
 Reporter:  scribu                      |       Owner:
     Type:  enhancement                 |      Status:  assigned
 Priority:  normal                      |   Milestone:  Future Release
Component:  Rewrite Rules               |     Version:
 Severity:  normal                      |  Resolution:
 Keywords:  needs-unit-tests has-patch  |     Focuses:  performance
Changes (by ericlewis):

 * milestone:  4.5 => Future Release


 Let's move this off the 4.5 milestone.

 We should think on a few things here:

 * `find_match()` as it currently stands is more or less a static function.
 Should we make the function a proper class method and look at registered
 rewrite rules (`$wp_rewrite->wp_rewrite_rules()`)?
 * The fact that the function requires `$request` and `$request_uri` is
 confusing. I wonder if we can boil the function input down to `$request`.

Ticket URL: <https://core.trac.wordpress.org/ticket/18877#comment:16>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform

More information about the wp-trac mailing list