[wp-trac] [WordPress Trac] #35804: Add post type to the oEmbed iframe 'title' attribute

WordPress Trac noreply at wordpress.org
Fri Feb 12 21:43:36 UTC 2016


#35804: Add post type to the oEmbed iframe 'title' attribute
--------------------------+-----------------------------
 Reporter:  ramiy         |       Owner:
     Type:  defect (bug)  |      Status:  new
 Priority:  normal        |   Milestone:  Future Release
Component:  Embeds        |     Version:
 Severity:  normal        |  Resolution:
 Keywords:  needs-patch   |     Focuses:  accessibility
--------------------------+-----------------------------

Comment (by ramiy):

 Replying to [comment:5 ocean90]:
 > `esc_attr__()` should be `esc_attr()`

 Done.

 > `-` should be `—`

 Done.

 > In the translators comment a comma should be used

 Done.

 > What about removing "embedded" from the title? Something like
 `“%1$s” from %2$s` ("Post title" from site name).

 Not sure about is. @swissspidy convinced me to add site-title, it is more
 representative. Besides, only blind people see the title attribute. They
 should know that it's an embedded content from external site.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/35804#comment:6>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list