[wp-trac] [WordPress Trac] #39335: Twenty Seventeen: customize-controls.js incorrectly assumes theme_options section is always present

WordPress Trac noreply at wordpress.org
Tue Dec 20 22:16:37 UTC 2016


#39335: Twenty Seventeen: customize-controls.js incorrectly assumes theme_options
section is always present
---------------------------+----------------------------
 Reporter:  westonruter    |       Owner:  davidakennedy
     Type:  defect (bug)   |      Status:  closed
 Priority:  normal         |   Milestone:  4.7.1
Component:  Bundled Theme  |     Version:  4.7
 Severity:  normal         |  Resolution:  fixed
 Keywords:  has-patch      |     Focuses:
---------------------------+----------------------------
Changes (by davidakennedy):

 * status:  reviewing => closed
 * resolution:   => fixed


Comment:

 In [changeset:"39623"]:
 {{{
 #!CommitTicketReference repository="" revision="39623"
 Twenty Seventeen: Ensure functions in `customize-controls.js` don't count
 on Customizer sections always being present

 Before, the code assumed the `theme_options` section is always present,
 but it can be removed by plugins. This way, if it is, no JavaScript errors
 occur.

 Props westonruter.

 Fixes #39335.
 }}}

--
Ticket URL: <https://core.trac.wordpress.org/ticket/39335#comment:3>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list