[wp-trac] [WordPress Trac] #39323: Twenty Seventeen: wp_resource_hints when enqueue custom fonts in child theme

[WordPress Trac]

#39323: Twenty Seventeen: wp_resource_hints when enqueue custom fonts in child
theme
-------------------------------+------------------------------
 Reporter:  sami.keijonen      |       Owner:
     Type:  enhancement        |      Status:  new
 Priority:  normal             |   Milestone:  Awaiting Review
Component:  Bundled Theme      |     Version:  4.7
 Severity:  normal             |  Resolution:
 Keywords:  reporter-feedback  |     Focuses:
-------------------------------+------------------------------
Changes (by davidakennedy):

 * keywords:   => reporter-feedback


Comment:

 Hey @sami.keijonen! Thanks for the enhancement request!

 I like the idea of this, but I also wonder: if you dequeue
 `twentyseventeen-fonts`, I think it makes sense the `wp_style_is` check is
 `false`. We don't know what a child theme's intentions are if they've
 dequeued something. Maybe its just system fonts the theme is after so this
 function or a themer's knowledge of it being there isn't needed. I think
 at a certain point, once a child theme does certain things, they're on
 their own, so to speak.

 I'm leaning toward not doing this, but open to feedback and more
 discussion.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/39323#comment:1>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform