[wp-trac] [WordPress Trac] #39101: Customize: edit shortcuts for custom menu widgets do not work

[WordPress Trac]

#39101: Customize: edit shortcuts for custom menu widgets do not work
------------------------------+--------------------------
 Reporter:  celloexpressions  |       Owner:  westonruter
     Type:  defect (bug)      |      Status:  reviewing
 Priority:  normal            |   Milestone:  4.7.1
Component:  Customize         |     Version:  4.7
 Severity:  normal            |  Resolution:
 Keywords:  has-patch commit  |     Focuses:
------------------------------+--------------------------

Comment (by sirbrillig):

 @westonruter nice sleuthing! Confirmed that that fixes the bug, in that it
 allows the edit shortcut for menus in widgets to work again.

 That said (and your patch should be committed regardless), I wonder which
 is the better experience for users?

 Clicking on the (fixed) menu shortcut brings up the editor for that menu.

 [[Image(https://cldup.com/7lTAzaHguo.png)]]

 Clicking on the widget shortcut brings up the widget settings, which allow
 changing which menu is displayed there.

 [[Image(https://cldup.com/mWvyLgbTc1.png)]]

 It seems to me that both could be what a user might be looking for, but
 obviously we can only allow one. Since you can click the "Edit Menu"
 button to get from the widget settings to the menu settings and not the
 other way around, I suggest we hide the menu shortcut anyway, but I'm open
 to a dissenting opinion.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/39101#comment:8>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform