[wp-trac] [WordPress Trac] #39259: 'custom_css_post_id' theme mod of `-1` doesn't prevent queries

[WordPress Trac]

#39259: 'custom_css_post_id' theme mod of `-1` doesn't prevent queries
--------------------------+--------------------------
 Reporter:  dlh           |       Owner:  westonruter
     Type:  defect (bug)  |      Status:  accepted
 Priority:  normal        |   Milestone:  4.7.1
Component:  Customize     |     Version:  4.7
 Severity:  normal        |  Resolution:
 Keywords:  has-patch     |     Focuses:
--------------------------+--------------------------

Comment (by westonruter):

 Replying to [comment:1 dlh]:
 > [attachment:39259.2.diff] revises the change to
 `wp_update_custom_css_post()` so that the theme mod is set only when
 updating the Custom CSS for the current stylesheet. But now I'm not quite
 sure how updates to other stylesheets would have to work with respect to
 the theme mod.

 Yeah, that's a limitation with Custom CSS in general right now, and more
 fundamentally with the theme mod API. I don't think there's a case in core
 where `custom_css` is updated when the target stylesheet is not currently
 active, and I don't think the changes in the patch here introduce anything
 new in that regard.

 PR: https://github.com/xwp/wordpress-develop/pull/212

--
Ticket URL: <https://core.trac.wordpress.org/ticket/39259#comment:4>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform