[wp-trac] [WordPress Trac] #39246: Theme deletion has a JS error that prevents multiple themes from being deleted.

[WordPress Trac]

#39246: Theme deletion has a JS error that prevents multiple themes from being
deleted.
--------------------------+-------------------------
 Reporter:  Hristo Sg     |       Owner:  obenland
     Type:  defect (bug)  |      Status:  accepted
 Priority:  normal        |   Milestone:  4.7.1
Component:  Themes        |     Version:  trunk
 Severity:  normal        |  Resolution:
 Keywords:                |     Focuses:  javascript
--------------------------+-------------------------
Changes (by obenland):

 * owner:   => obenland
 * status:  new => accepted
 * focuses:   => javascript


Old description:

> In order to recreate the problem:
> - install multiple themes
> - delete a theme and close the window
> - try deleting a second one - it fails
>
> on the first deletion, I see a JS error in the console:
> Error: Syntax error, unrecognized expression: [data-slug="twentyfifteen"
>
> In the wp-admin/js/theme.js there is a line:
>
> $( '[data-slug="' + response.slug + '"' ).css( {
> backgroundColor:'#faafaa' } ).fadeOut( 350, function() {
>
> in which I believe the shortcode is not closed and should be
>
> $( '[data-slug="' + response.slug + '"]' ).css( {
> backgroundColor:'#faafaa' } ).fadeOut( 350, function() {
>
> I was testing on Safari Version 10.0.1 (12602.2.14.0.7)

New description:

 In order to recreate the problem:
 - install multiple themes
 - delete a theme and close the window
 - try deleting a second one - it fails

 on the first deletion, I see a JS error in the console:
 `Error: Syntax error, unrecognized expression: [data-slug="twentyfifteen"`

 In the wp-admin/js/theme.js there is a line:

 `$( '[data-slug="' + response.slug + '"' ).css( {
 backgroundColor:'#faafaa' } ).fadeOut( 350, function() {`

 in which I believe the shortcode is not closed and should be

 `$( '[data-slug="' + response.slug + '"]' ).css( {
 backgroundColor:'#faafaa' } ).fadeOut( 350, function() {`

 I was testing on Safari Version 10.0.1 (12602.2.14.0.7)

--

--
Ticket URL: <https://core.trac.wordpress.org/ticket/39246#comment:2>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform