[wp-trac] [WordPress Trac] #39101: Customize: edit shortcuts for custom menu widgets do not work

WordPress Trac noreply at wordpress.org
Sat Dec 10 16:42:08 UTC 2016


#39101: Customize: edit shortcuts for custom menu widgets do not work
------------------------------+-------------------------
 Reporter:  celloexpressions  |       Owner:  sirbrillig
     Type:  defect (bug)      |      Status:  assigned
 Priority:  normal            |   Milestone:  4.7.1
Component:  Customize         |     Version:  4.7
 Severity:  normal            |  Resolution:
 Keywords:  needs-patch       |     Focuses:
------------------------------+-------------------------

Comment (by sanket.parmar):

 Hi @celloexpressions ,

 What if we don't load an edit icon for custom menu widgets. I mean on
 [https://core.trac.wordpress.org/browser/tags/4.7/src/wp-includes/class-
 wp-customize-nav-menus.php#L1298] line we add one extra condition to check
 `fallback_cb` is not empty ( i.e., `! empty(
 $args->customize_preview_nav_menus_args['fallback_cb'] )`). This way the
 edit icon will not load for custom menu widgets.

 Let me know your thoughts.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/39101#comment:3>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list