[wp-trac] [WordPress Trac] #39212: Replace is_super_admin() check with current_user_can( 'manage_network_users' ) in wp-admin/includes/ms.php

WordPress Trac noreply at wordpress.org
Fri Dec 9 16:56:15 UTC 2016


#39212: Replace is_super_admin() check with current_user_can(
'manage_network_users' ) in wp-admin/includes/ms.php
-------------------------------------+------------------------
 Reporter:  bhargavbhandari90        |       Owner:  flixos90
     Type:  enhancement              |      Status:  reviewing
 Priority:  normal                   |   Milestone:  4.8
Component:  Role/Capability          |     Version:
 Severity:  normal                   |  Resolution:
 Keywords:  has-patch needs-refresh  |     Focuses:  multisite
-------------------------------------+------------------------
Changes (by flixos90):

 * keywords:   => has-patch needs-refresh
 * owner:   => flixos90
 * focuses:   => multisite
 * status:  new => reviewing
 * milestone:  Awaiting Review => 4.8


Comment:

 Thanks for the patch @bhargavbhandari90! It looks good so far, there are
 only two small adjustments that should be made, which are both related to
 coding standards:

 * insert a space between the `!` and `current_user_can(
 'manage_network_users' )`
 * add curly braces around the clause (this is an acceptable change since
 we are adjusting that code anyway)

--
Ticket URL: <https://core.trac.wordpress.org/ticket/39212#comment:1>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list