[wp-trac] [WordPress Trac] #39206: Replace `is_super_admin()` with `current_user_can( 'manage_options' )` in wp-admin/network.php (was: Replace current_user_can( 'manage_options' ) in wp-admin/network.php)

WordPress Trac noreply at wordpress.org
Fri Dec 9 16:39:16 UTC 2016


#39206: Replace `is_super_admin()` with `current_user_can( 'manage_options' )` in
wp-admin/network.php
-------------------------------------+------------------------
 Reporter:  ashokkumar24             |       Owner:  flixos90
     Type:  enhancement              |      Status:  reviewing
 Priority:  normal                   |   Milestone:  4.8
Component:  Role/Capability          |     Version:
 Severity:  normal                   |  Resolution:
 Keywords:  has-patch needs-refresh  |     Focuses:  multisite
-------------------------------------+------------------------
Changes (by flixos90):

 * status:  new => reviewing
 * owner:   => flixos90
 * milestone:  Awaiting Review => 4.8
 * keywords:   => has-patch needs-refresh
 * type:  defect (bug) => enhancement


Old description:

> This is part of the #37616 task. There are 2 is_super_admin() checks in
> wp-admin/network.php that should be replaced with current_user_can(
> 'manage_network' ).

New description:

 This is part of the #37616 task. There is 1 `is_super_admin()` check in
 wp-admin/network.php that should be replaced with `current_user_can(
 'manage_options' )`.

--

Comment:

 Thanks for the patch @ashokkumar24! You are using the `manage_network`
 capability there although it should be `manage_options` (see "Ticket 15"
 in https://core.trac.wordpress.org/ticket/37616#comment:28 for reference)
 - could you update the patch accordingly?

--
Ticket URL: <https://core.trac.wordpress.org/ticket/39206#comment:1>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list