[wp-trac] [WordPress Trac] #39200: Replace `is_super_admin()` check with current_user_can( 'manage_network_options' ) in wp-admin/options.php

WordPress Trac noreply at wordpress.org
Fri Dec 9 16:04:13 UTC 2016


#39200: Replace `is_super_admin()` check with current_user_can(
'manage_network_options' ) in wp-admin/options.php
-----------------------------+------------------------
 Reporter:  sathyapulse      |       Owner:  flixos90
     Type:  enhancement      |      Status:  assigned
 Priority:  normal           |   Milestone:  4.8
Component:  Role/Capability  |     Version:
 Severity:  normal           |  Resolution:
 Keywords:  has-patch        |     Focuses:  multisite
-----------------------------+------------------------
Changes (by flixos90):

 * status:  new => assigned
 * focuses:   => multisite
 * owner:   => flixos90
 * milestone:  Awaiting Review => 4.8
 * keywords:   => has-patch
 * type:  defect (bug) => enhancement


Comment:

 Hi @sathyapulse, and thanks for the patch! It looks good so far. One minor
 thing we could adjust is to add curly braces around the clause in line
 163: Since we are changing the line anyway, it's a good habit to adjust
 this clause to follow the proper coding standards.

 Feel free to update your patch accordingly, that would be great! :)

--
Ticket URL: <https://core.trac.wordpress.org/ticket/39200#comment:1>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list