[wp-trac] [WordPress Trac] #39073: Twenty Seventeen header image is compressed

WordPress Trac noreply at wordpress.org
Sun Dec 4 23:11:19 UTC 2016


#39073: Twenty Seventeen header image is compressed
-------------------------------------------+----------------------------
 Reporter:  dlh                            |       Owner:  davidakennedy
     Type:  defect (bug)                   |      Status:  closed
 Priority:  normal                         |   Milestone:  4.7
Component:  Bundled Theme                  |     Version:  trunk
 Severity:  normal                         |  Resolution:  fixed
 Keywords:  has-patch commit dev-reviewed  |     Focuses:
-------------------------------------------+----------------------------
Changes (by davidakennedy):

 * owner:   => davidakennedy
 * status:  new => closed
 * resolution:   => fixed


Comment:

 In [changeset:"39495"]:
 {{{
 #!CommitTicketReference repository="" revision="39495"
 Twenty Seventeen: Fix CSS specificity problem with CSS feature query for
 `object-fit`

 Previously, the theme's CSS feature query for `object-fit` overrode styles
 it shouldn't have on interior pages.

 This moves the feature query farther down in the stylesheet so it takes
 precedence in the cascade in supported browsers, and applies the
 appropriate selector for the interior pages. In browsers that don't
 support feature queries or `object-fit`, the fallback styles are still
 applied. The problem was that the rules had the same specificity, so this
 way, the cascade takes over properly. The transforms and position changes
 for fallbacks are still needed in browsers that don't support `object-fit`
 and feature queries.

 Props peterwilsoncc, davidakennedy.

 Fixes #39073.
 }}}

--
Ticket URL: <https://core.trac.wordpress.org/ticket/39073#comment:11>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list