[wp-trac] [WordPress Trac] #32816: No or inadequate Custom Link URL validation

[WordPress Trac]

#32816: No or inadequate Custom Link URL validation
-------------------------------------------------+-------------------------
 Reporter:  JanR                                 |       Owner:
     Type:  enhancement                          |      Status:  new
 Priority:  normal                               |   Milestone:  4.8
Component:  Customize                            |     Version:  4.3
 Severity:  normal                               |  Resolution:
 Keywords:  good-first-bug has-patch needs-      |     Focuses:  ui,
  testing                                        |  javascript
-------------------------------------------------+-------------------------

Comment (by celloexpressions):

 In addition to using setting validation, this should really be checked on
 the form where the custom URL is most often entered in the first place, in
 the available menu items panel. That would provide a better user
 experience by blocking invalid items from being added in the first place,
 and could be backed up with this setting validation in case users edit the
 value in the menu item properties.

 There is already some basic JS validation on that input, making sure it
 isn't blank or left at the default `http://` in case users forget to add a
 link. That should be extended to make similar checks to what will happen
 in php with the recent patches.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/32816#comment:10>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform