[wp-trac] [WordPress Trac] #38681: Rename WP_User::for_blog() to WP_User::for_site()

[WordPress Trac]

#38681: Rename WP_User::for_blog() to WP_User::for_site()
--------------------------------------+------------------------
 Reporter:  flixos90                  |       Owner:
     Type:  enhancement               |      Status:  new
 Priority:  normal                    |   Milestone:  4.8
Component:  Users                     |     Version:
 Severity:  normal                    |  Resolution:
 Keywords:  has-patch has-unit-tests  |     Focuses:  multisite
--------------------------------------+------------------------
Changes (by flixos90):

 * keywords:  has-patch 2nd-opinion => has-patch has-unit-tests


Comment:

 [attachment:38681.2.diff] adds unit tests for using both the old and the
 new method name.

 While this change on its own does not make sense as we shouldn't do plain
 refactoring, it is worth doing in regards to #38645. New code should use
 the new multisite naming conventions (site instead of blog), and the
 inconsistency in naming that we would get from introducing the new method
 there is worse than the change of renaming here.

 Let's commit this together with #38645 once it's ready.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/38681#comment:4>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform