[wp-trac] [WordPress Trac] #38989: Invalid meta causes warning in WP_Test_REST_Post_Meta_Fields

WordPress Trac noreply at wordpress.org
Fri Dec 2 19:15:28 UTC 2016


#38989: Invalid meta causes warning in WP_Test_REST_Post_Meta_Fields
--------------------------------------+--------------------------
 Reporter:  timmydcrawford            |       Owner:  rachelbaker
     Type:  defect (bug)              |      Status:  assigned
 Priority:  normal                    |   Milestone:  4.7
Component:  REST API                  |     Version:  trunk
 Severity:  normal                    |  Resolution:
 Keywords:  has-patch has-unit-tests  |     Focuses:
--------------------------------------+--------------------------
Changes (by rachelbaker):

 * keywords:  has-patch has-unit-tests 2nd-opinion => has-patch has-unit-
               tests


Comment:

 @jnylen0 Your [attachment:38989.4.diff] looked good, I only had minor
 feedback:
 - let's use the validate_callback instead because we aren't really
 sanitizing the array
 - rename the callback `check_` to closely match the naming convention of
 our custom callbacks

 In the interest of time I did both of these in [attachment:38989.5.diff] -
 is this acceptable?  If you agree, I will go ahead and apply the `commit`
 keyword so we can move this forward.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/38989#comment:10>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list