[wp-trac] [WordPress Trac] #38995: Twenty Seventeen: Custom headers incorrect on mobile when no image is set.

WordPress Trac noreply at wordpress.org
Fri Dec 2 04:24:34 UTC 2016


#38995: Twenty Seventeen: Custom headers incorrect on mobile when no image is set.
-------------------------------------------+------------------------
 Reporter:  joemcgill                      |       Owner:  joemcgill
     Type:  defect (bug)                   |      Status:  accepted
 Priority:  normal                         |   Milestone:  4.7
Component:  Bundled Theme                  |     Version:  trunk
 Severity:  normal                         |  Resolution:
 Keywords:  has-patch commit dev-feedback  |     Focuses:
-------------------------------------------+------------------------
Changes (by joemcgill):

 * keywords:  has-patch dev-feedback => has-patch commit dev-feedback


Comment:

 [attachment:38995.7.patch] updates [attachment:38995.6.patch] as mentioned
 in [https://core.trac.wordpress.org/ticket/38995#comment:14 Laurel's
 comment]. Worth noting that this reverts the change made in [39392] but
 doesn't reintroduce the bug from #38927 because of the addition of a check
 for `.has-header-image` or `.has-header-video` in global.js, i.e.:

 {{{
 if ( isFrontPage && ( $body.hasClass( 'has-header-image' ) ||
 $body.hasClass( 'has-header-video' ) ) ) { ... }
 }}}

--
Ticket URL: <https://core.trac.wordpress.org/ticket/38995#comment:16>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list