[wp-trac] [WordPress Trac] #38995: Twenty Seventeen: Custom headers incorrect on mobile when no image is set.

WordPress Trac noreply at wordpress.org
Fri Dec 2 00:40:23 UTC 2016


#38995: Twenty Seventeen: Custom headers incorrect on mobile when no image is set.
------------------------------------+------------------------
 Reporter:  joemcgill               |       Owner:  joemcgill
     Type:  defect (bug)            |      Status:  accepted
 Priority:  normal                  |   Milestone:  4.7
Component:  Bundled Theme           |     Version:  trunk
 Severity:  normal                  |  Resolution:
 Keywords:  has-patch dev-feedback  |     Focuses:
------------------------------------+------------------------

Comment (by laurelfulford):

 Nice - thanks @joemcgill!

 The only thing that didn't seem to carry over was the change I made in
 [attachment:38995.5.patch] - in header-image.php, this bit:
 {{{
 <?php if ( has_custom_header() ) : ?>
         <div class="custom-header-media">
                 <?php the_custom_header_markup(); ?>
         </div>
 <?php endif; ?>
 }}}

 ... should just be:

 {{{
 <div class="custom-header-media">
         <?php the_custom_header_markup(); ?>
 </div>
 }}}

 Everything else looks to be there!

--
Ticket URL: <https://core.trac.wordpress.org/ticket/38995#comment:14>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list