[wp-trac] [WordPress Trac] #38990: REST API: admin_email setting description is inaccurate

WordPress Trac noreply at wordpress.org
Thu Dec 1 16:22:51 UTC 2016


#38990: REST API: admin_email setting description is inaccurate
-------------------------------------+----------------------------------
 Reporter:  johnbillion              |       Owner:  joehoyle
     Type:  defect (bug)             |      Status:  assigned
 Priority:  normal                   |   Milestone:  4.7
Component:  Options, Meta APIs       |     Version:  trunk
 Severity:  normal                   |  Resolution:
 Keywords:  needs-patch i18n-change  |     Focuses:  multisite, rest-api
-------------------------------------+----------------------------------

Comment (by joehoyle):

 > On Multisite, the admin_email input field is actually for an option
 named new_admin_email which gets set immediately when the form is saved.
 Only after the user clicks the link in their confirmation email, does the
 actual admin_email option get updated.

 I'm not totally sure why this exists in multisite and not in single site?

 On the assumption that we want to continue with that, we probably need to
 run a custom update hook by using `rest_pre_update_setting` which I guess
 if you try to update it on multisite it will noop the update, and instead
 trigger the confirmation email. How does that sound? I can put together a
 patch.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/38990#comment:14>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list