[wp-trac] [WordPress Trac] #37863: HTTP/1.1 defined header in wp-comments-post.php

WordPress Trac noreply at wordpress.org
Wed Aug 31 05:11:17 UTC 2016


#37863: HTTP/1.1 defined header in wp-comments-post.php
--------------------------+--------------------------
 Reporter:  tnash         |       Owner:  johnbillion
     Type:  defect (bug)  |      Status:  reopened
 Priority:  normal        |   Milestone:  4.7
Component:  Comments      |     Version:  4.6
 Severity:  normal        |  Resolution:
 Keywords:                |     Focuses:
--------------------------+--------------------------

Comment (by dd32):

 If I remember correctly; we've encountered misconfigured servers which
 pass `SERVER_PROTOCOL` as null or an invalid form (which is why we also
 support `HTTP/2`). In older versions of nginx it was also common to see
 the client connection as 1.1, but `SERVER_PROTOCOL` supplied to PHP as
 1.0.

 I don't see any major issue with falling back to `HTTP/1.0` in the event
 that a non-1.1/2/2.0 protocol is presented (as current) despite it not
 fitting the strict spec, we can add support for `HTTP/2.1` or `HTTP/3.0`
 when it's released in a decade, applications in the real world handle
 other applications responding with a lower version number, as part of
 their back-compat and iterative nature of the protocols.

 If we were to change something here, I'd suggest it should respect
 anything passed in the format of `HTTP/[0-9.]+` falling back to `HTTP/1.0`
 otherwise.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/37863#comment:6>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list